Remove data loading page in favor of the data fetching guide#995
Closed
amirhhashemi wants to merge 5 commits intosolidjs:mainfrom
Closed
Remove data loading page in favor of the data fetching guide#995amirhhashemi wants to merge 5 commits intosolidjs:mainfrom
amirhhashemi wants to merge 5 commits intosolidjs:mainfrom
Conversation
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
|
Hi @amirhhashemi, after speaking to some team members and thinking on it myself, I don't think we're going to remove the guide for the time being, even after the merge of the other PR. There are topics covered within this guide that need to be reworked somehow so we're going to have to revisit how to address the similarities. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description(required)
Do not merge this before #991
#991 adds a data fetching guide. Since almost all the material in the data loading page is covered in the new data fetching guide, there is no longer a use for this page